Need a developer. Idea for plugin - Separate combined shapes.

This site is best viewed in a modern browser with JavaScript enabled.

Need a developer. Idea for plugin - Separate combined shapes.

mathieudutour

PEZ I don't understand what you mean. You don't need to create an issue for it, we are not going to add it for you. Have a look here: https://github.com/sketchplugins/plugin-directory/blob/master/CONTRIBUTING.md

skpm publish is creating the pull request to the sketchplugins/plugin-directory repo so you don't have to do it manually. That's what it means to "publish a plugin" for now. So yes, skpm did its part.

Looks more like a patch to me. Which is what I expect a pull request to look like.

What?

I think the merge conflict comes from the fact that you already have the repo forked so skpm just branched from your old master (600 commits behind) instead of pulling the upstream before branching

PEZ

The old way of adding a plugin was to either do a pull request or file an issue. The instructions still say these are the options. So when skpm publish didn't seem to do that part, I filed an issue. I never thought about checking for a merge conflict.

Anyway, yes, I forked the repo long ago, adding another plugin.

And now I have gotten help adding the plugin to the repo. So that's dandy. Even if I still can't find it in the directory. Maybe it takes a while.

Mikola35

@PEZ Hello!
I tried plugin. It's great.

PEZ

Mikola35 Thanks!

I noticed I need to fix that it doesn't keep the generated layers inside any parent group that the original shapes resided in.

PEZ

Mikola35 You mean the compound shapes should be automatically split into separate shapes? I can look into that.

Regarding Runner I have made some preparations for that, but don't know how to add the image resource yet.

If you could file both these as issues towards the plugin's repo on Github, I'd be most happy.

Also, I fixed the issue where the generated layers where picked out of any containing group, as well as keeping the generating layer in the same place in the layer stack as the bottom original layer. Upgrade it.

PEZ

Mikola35 In this case (https://www.dropbox.com/s/dugni1qjw7k2ur7/screencast%2802-12-28%29%2801-02-18%29_9t6zd.mp4?dl=0) I think shapes should be split auto.

This is now fixed. Time to upgrade.

There are a few funny cases that I don't know how to deal with. Like if there is complete overlap between two shapes, it doesn't seem that I do the right thing.

PEZ

HugoLuc I think I might now have stumbled across a problem with winding rules: https://github.com/PEZ/SketchSeparateShapes/issues/4

Did you find out anything about how to get that information from Sketch?

ale

PEZ added a comment on the issue, hope it helps!

PEZ

ale Thanks!

I am not convinced it is a winding rule issue, or even if it is, how I can use the winding rule information to mitigate the issue. I have two shapes to consider…

Winding rules or not, if the plugin fails splitting the shape by the line, then switching the end and start points of the line will make the plugin split the shape correctly. I'm currently trying to figure out if I can build this workaround into the code somehow. Does that make sense?

PEZ

@Mikola35 New version out. It can do multi-split:

Multisplit demo

No idea if you have ever wanted to do that, but anyway.

Mikola35

@PEZ Do you saw?
Sketch team write about this plugin in their "Sketch News"
https://sketch.curated.co/issues/44#start