MSPasteboardManager.writeXX seems to be broken on Sketch 70.5

romannurik

Calling MSPasteboardManager.writePasteboardLayers_toPasteboard like so:

// 'layer' is a native sketch object
MSPasteboardManager.writePasteboardLayers_toPasteboard(
    MSPasteboardLayers.pasteboardLayersWithLayers([layer]),
    NSPasteboard.pasteboardWithName(NSDragPboard));

seems to be broken, throwing an Objective-C exception:

NSInvalidArgumentException *** -[NSMutableArray addObjectsFromArray:]: array argument is not an NSArray
_NSCallStackArray [
  '0   CoreFoundation                      0x00007fff384f2b57 __exceptionPreprocess + 250',
  '1   libobjc.A.dylib                     0x00007fff713375bf objc_exception_throw + 48',
  '2   CoreFoundation                      0x00007fff385a159e -[__NSCFString characterAtIndex:].cold.1 + 0',
  '3   CoreFoundation                      0x00007fff385a7708 -[NSMutableArray addObjectsFromOrderedSet:range:].cold.1 + 0',
  '4   CoreFoundation                      0x00007fff3846525e -[NSMutableArray addObjectsFromArray:] + 582',
  '5   BCFoundation                        0x0000000100e59c77 +[NSArray(BCFoundation) arrayByMergingArrays:] + 279',
  '6   SketchModel                         0x00000001015b1a82 -[MSPasteboardManager writePasteboardLayers:toPasteboard:] + 162',
...

Any ideas anyone :-)

romannurik

romannurik Oh and yes, passing an empty array ([]) throws the same error as [layer].

romannurik

I've found a workaround, basically getting access to the MSPasteboardLayersReaderWriter and using its writeData_toPasteboard method directly:

let layerWriter = Array.from(NSApp.delegate().pasteboardManager().writers())
    .find(x => String(x.className()) === 'MSPasteboardLayersReaderWriter');
layerWriter.writeData_toPasteboard(
    MSPasteboardLayers.pasteboardLayersWithLayers([layer]),
    NSPasteboard.pasteboardWithName(NSDragPboard));

kevgski

Huh thats kinda strange… I imagine you are doing some drag and drop stuff eh? I haven't had a chance to work with that yet. I think the Sketch folks probably have the most insight as to what might have changed with that internal method.

kevgski

For whatever reason you need to ensure that your layer array is an NSArray.

This seems to work for me:

let sketch = require('sketch')
let doc = sketch.getSelectedDocument()
let selection = doc.selectedLayers.layers[0].sketchObject
let layerArray = MSLayerArray.arrayWithLayer(selection)

let pasteboard = NSPasteboard.generalPasteboard()
let mspLayers = MSPasteboardLayers.pasteboardLayersWithLayers(layerArray.layers())
MSPasteboardManager.writePasteboardLayers_toPasteboard(mspLayers,pasteboard)

I was thinking you needed to explicitly pass in a MSLayerArray but that didn't work so I dropped down to the NSArray using this method: https://github.com/abynim/Sketch-Headers/blob/master/Headers/MSLayerArray.h#L16